config/kernel-inode-times: initialize timespec #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of this variable uninitialized triggers -Werror,-Wuninitialized when compiled under clang for linux kernel 5.6, leading the build system to believe that the function is not declared. This commit initalizes the variable to suppress the warning and fix the build for kernel 5.6 with clang. Fixes openzfs#10279 Signed-off-by: Hiếu Lê <leorize+oss@disroot.org>
behlendorf
approved these changes
May 1, 2020
behlendorf
added
the
Type: Building
lkthomas
reviewed
May 2, 2020
There was a problem hiding this comment.
confirmed working on Fedora 31,
LSB Version: :core-4.1-amd64:core-4.1-noarch
Distributor ID: Fedora
Description: Fedora release 31 (Thirty One)
Release: 31
Codename: ThirtyOne
Linux localhost.localdomain 5.6.7-200.fc31.x86_64 #1 SMP Thu Apr 23 14:22:57 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Codecov Report
@@ Coverage Diff @@
## master #10281 +/- ##
==========================================
- Coverage 79.52% 79.48% -0.04%
==========================================
Files 389 389
Lines 123120 123120
==========================================
- Hits 97906 97868 -38
- Misses 25214 25252 +38
Continue to review full report at Codecov.
|
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
Usage of this variable uninitialized triggers -Werror,-Wuninitialized when compiled under clang for linux kernel 5.6, leading the build system to believe that the function is not declared. This commit initializes the variable to suppress the warning and fix the build for kernel 5.6 with clang. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Hiếu Lê <leorize+oss@disroot.org> Closes openzfs#10279 Closes openzfs#10281 (cherry picked from commit 3e5d41d)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Usage of this variable uninitialized triggers -Werror,-Wuninitialized when compiled under clang for linux kernel 5.6, leading the build system to believe that the function is not declared. This commit initializes the variable to suppress the warning and fix the build for kernel 5.6 with clang. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Hiếu Lê <leorize+oss@disroot.org> Closes openzfs#10279 Closes openzfs#10281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Usage of the uninitalized
timespec64triggers-Werror,-Wuninitializedwhen compiled under clang for linux kernel 5.6, leading the build system
to believe that the function is not declared. This in turn breaks the build.
See #10279
Description
Initializes the said variable to suppress the warning.
How Has This Been Tested?
Tested on my own system.
Types of changes
Checklist:
Signed-off-by.