Fixed LDADD library links in Makefiles for cross compilation builds. #10304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building on native dev system, there are no issues but when cross-compiling for target system, some linker errors are observed. The only way to avoid these errors is by adjusting the Makefile.am of those various components to add the library dependencies. Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com>
behlendorf
approved these changes
May 8, 2020
gmelikov
approved these changes
May 8, 2020
behlendorf
added
Status: Accepted
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
When building on native dev system, there are no issues but when cross-compiling for target system, some linker errors are observed. The only way to avoid these errors is by adjusting the Makefile.am of those various components to add the library dependencies. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com> Closes openzfs#10304 (cherry picked from commit bd95f00)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
When building on native dev system, there are no issues but when cross-compiling for target system, some linker errors are observed. The only way to avoid these errors is by adjusting the Makefile.am of those various components to add the library dependencies. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com> Closes openzfs#10304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When building on native dev system, there are no issues but when cross-compiling for a target system (even after running
./autogen.sh && ./configure), some linker errors are observed. See example error below:Description
The only way to avoid these errors is by adjusting the
Makefile.amof those various components to add the library dependencies.How Has This Been Tested?
This has been built and the affected utilities have been functional tested in both the native dev environment (running Ubuntu Server 18.04 LTS) and again in the cross-compiled target environment (running a custom minimal LFS distribution using the 5.4.37 kernel, GCC 7.5 and glibc 2.30).
Types of changes
Checklist:
Signed-off-by.