ZTS: zpool_split_indirect deletes zfstest log file #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanup routine for this test attempts to remove some temporary files with `rm -f $VDEV_*`, but VDEV_ is undefined. As a result, all files in the current working directory (/var/tmp/test_results/current) get removed instead. This includes the complete log file of all tests. Signed-off-by: John Kennedy <john.kennedy@delphix.com>
behlendorf
approved these changes
May 13, 2020
behlendorf
added
Status: Code Review Needed
|
cc: @gamanakis |
behlendorf
added
Status: Accepted
|
Good catch, thank you! |
gmelikov
approved these changes
May 14, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The cleanup routine for this test attempts to remove some temporary files with `rm -f $VDEV_*`, but VDEV_ is undefined. As a result, all files in the current working directory (/var/tmp/test_results/current) get removed instead. This includes the complete log file of all tests. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: George Amanakis <gamanakis@gmail.com> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: John Kennedy <john.kennedy@delphix.com> Closes openzfs#10324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Kennedy john.kennedy@delphix.com
Motivation and Context
The cleanup routine for this test attempts to remove some temporary
files with
rm -f $VDEV_*, but VDEV_ is undefined. As a result, allfiles in the current working directory (/var/tmp/test_results/current)
get removed instead. This includes the complete log file of all tests.
Description
Change the
rmto explicitly delete the created files.How Has This Been Tested?
Ran the suite without any changes, and verified the log disappears during zpool_split_indirect.
Then ran the suite again with this change and verified the log doesn't get deleted.
Types of changes
Checklist:
Signed-off-by.