-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ZVOL_DIR #10337
Fix ZVOL_DIR #10337
Conversation
We only use ZVOL_DIR on FreeBSD, and on FreeBSD it isn't correct. Move the definition to the file where it is needed, and define it as /dev/zvol/. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Codecov Report
@@ Coverage Diff @@
## master #10337 +/- ##
==========================================
- Coverage 79.88% 79.38% -0.50%
==========================================
Files 292 390 +98
Lines 83481 123350 +39869
==========================================
+ Hits 66686 97924 +31238
- Misses 16795 25426 +8631
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #10337 +/- ##
==========================================
- Coverage 79.88% 79.64% -0.24%
==========================================
Files 292 390 +98
Lines 83481 123350 +39869
==========================================
+ Hits 66686 98241 +31555
- Misses 16795 25109 +8314
Continue to review full report at Codecov.
|
We only use ZVOL_DIR on FreeBSD, and on FreeBSD it isn't correct. Move the definition to the file where it is needed, and define it as /dev/zvol/. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10337
Motivation and Context
We only use ZVOL_DIR on FreeBSD, and on FreeBSD it isn't even correct.
Description
Move the definition to the file where it is needed, and define it as
/dev/zvol/.
How Has This Been Tested?
Ran tests for the zvol tag on FreeBSD.
Types of changes
Checklist:
Signed-off-by
.