-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arc: Periodically update ARC kstats #10371
Conversation
FreeBSD needs arc_adjust_zthr to run periodically for kstats to be updated. A comment in the code suggests this may have been the original intent in illumos as well: https://github.com/openzfs/zfs/blob/c946d5a91329b075fb9bda1ac703a2e85139cf1c/module/zfs/arc.c#L4697-L4700 Create the thread with a 1 second timer. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Codecov Report
@@ Coverage Diff @@
## master #10371 +/- ##
==========================================
+ Coverage 79.52% 79.75% +0.23%
==========================================
Files 391 391
Lines 123590 123590
==========================================
+ Hits 98288 98575 +287
+ Misses 25302 25015 -287
Continue to review full report at Codecov.
|
I thought this got committed, weird |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was in the initial port and was only reverted to minimize the diff when merging.
FreeBSD needs arc_adjust_zthr to run periodically for kstats to be updated. A comment in the code suggests this may have been the original intent in illumos as well: https://github.com/openzfs/zfs/blob/c946d5a91329b075fb9bda1ac703a2e85139cf1c/module/zfs/arc.c#L4697-L4700 Create the thread with a 1 second timer. Reviewed-by: Matt Macy <mmacy@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10371
Motivation and Context
FreeBSD needs arc_adjust_zthr to run periodically for kstats to be
updated. A comment in the code suggests this may have been the
original intent in illumos as well:
zfs/module/zfs/arc.c
Lines 4697 to 4700 in c946d5a
Description
Create the thread with a 1 second timer.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.