FreeBSD: Simplify zvol and fix locking #10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Component: ZVOL
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## master #10381 +/- ##
===========================================
- Coverage 79.38% 66.00% -13.39%
===========================================
Files 391 308 -83
Lines 123590 106289 -17301
===========================================
- Hits 98112 70151 -27961
- Misses 25478 36138 +10660
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #10381 +/- ##
===========================================
- Coverage 79.38% 66.02% -13.37%
===========================================
Files 391 308 -83
Lines 123590 106289 -17301
===========================================
- Hits 98112 70176 -27936
- Misses 25478 36113 +10635
Continue to review full report at Codecov.
|
|
@mattmacy can you give this some eyeballs |
|
Seems fine. |
mattmacy
approved these changes
Jun 1, 2020
zvol_geom_bio_strategy should handle its own use of the zvol suspend reader lock and ensure the zilog exists when needed. A few other places using the zvol zilog should use the suspend reader lock as well. Simplify consumers of zvol_geom_bio_strategy, fix the locking, and while in here, use the boolean_t constants with doread. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
|
mattmacy
approved these changes
Jun 2, 2020
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
zvol_geom_bio_strategy should handle its own use of the zvol suspend reader lock and ensure the zilog exists when needed. A few other places using the zvol zilog should use the suspend reader lock as well. Simplify consumers of zvol_geom_bio_strategy, fix the locking, and while in here, use the boolean_t constants with doread. Reviewed-by: Matt Macy <mmacy@FreeBSD.org> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
zvol_geom_bio_strategy should handle its own use of the zvol
suspend reader lock and ensure the zilog exists when needed.
A few other places using the zvol zilog should use the suspend
reader lock as well.
Description
Simplify consumers of zvol_geom_bio_strategy, fix the locking, and
while in here, use the boolean_t constants with doread.
How Has This Been Tested?
ZTS on FreeBSD:
Types of changes
Checklist:
Signed-off-by.