-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zfs-functions.in #10382
Update zfs-functions.in #10382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10382 +/- ##
==========================================
- Coverage 79.36% 79.22% -0.15%
==========================================
Files 391 391
Lines 123585 123585
==========================================
- Hits 98086 97907 -179
- Misses 25499 25678 +179
Continue to review full report at Codecov.
|
@gyakovlev @ryao would you mind reviewing this. |
@allen-4 thanks for looking in to this. Could you please your signed-off-by to the commit message and update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Allen Holl <allen.m.holl@gmail.com> Adding sign off to commit
@behlendorf Thank you, I added my sign-off. Hope I got it right, I'm very new to github. |
LGTM |
The init.d zfs-share script does not perform the intended action without having a variable set for ZFS_SHARE and ZFS_UNSHARE Assign default values to ZFS_SHARE and ZFS_UNSHARE. Export the environment variables after sourcing the configuration file. Reviewed-by: Richard Yao <ryao@gentoo.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Georgy Yakovlev <gyakovlev@gentoo.org> Signed-off-by: Allen Holl <allen.m.holl@gmail.com> Closes openzfs#10341 Closes openzfs#10382 (cherry picked from commit 4d829ad)
The init.d zfs-share script does not perform the intended action without having a variable set for ZFS_SHARE and ZFS_UNSHARE Assign default values to ZFS_SHARE and ZFS_UNSHARE. Export the environment variables after sourcing the configuration file. Reviewed-by: Richard Yao <ryao@gentoo.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Georgy Yakovlev <gyakovlev@gentoo.org> Signed-off-by: Allen Holl <allen.m.holl@gmail.com> Closes openzfs#10341 Closes openzfs#10382
Motivation and Context
Closes #10341
Related to bug #10341 and #10376
The init.d zfs-share script does not perform the intended action without having a variable set for ZFS_SHARE and ZFS_UNSHARE
Description
Assign default values to ZFS_SHARE and ZFS_UNSHARE. Export the environment variables after sourcing the configuration file.
How Has This Been Tested?
Tested on gentoo with kernel version 5.6.14
Types of changes
Checklist:
Signed-off-by
.