Upstream: add macOS calls to AVL #10390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10390 +/- ##
==========================================
- Coverage 79.68% 79.44% -0.24%
==========================================
Files 391 391
Lines 123603 123624 +21
==========================================
- Hits 98492 98217 -275
- Misses 25111 25407 +296
Continue to review full report at Codecov.
|
behlendorf
requested changes
Jun 1, 2020
There was a problem hiding this comment.
Thanks, it looks like only one minor addition is needed. Providing these extra public library functions shouldn't be a problem for any of the platforms, plus now that they're available we may find they'll be useful elsewhere. I also verified the code matches what's in illumos, just for good measure.
| */ | ||
| extern boolean_t avl_update(avl_tree_t *, void *); | ||
| extern boolean_t avl_update_lt(avl_tree_t *, void *); | ||
| extern boolean_t avl_update_gt(avl_tree_t *, void *); |
There was a problem hiding this comment.
Can you add these three new functions in order to the list of exported symbols at the end of module/avl/avl.c. The EXPORT_SYMBOL line is needed on Linux to be able to call the functions from a different kmod.
macOS kmem uses avl_update() and related functions. If other platforms get "defined but not used" warnings, they may need to be wrapped in #ifdefs. Signed-off-by: Jorgen Lundman <lundman@lundman.net>
behlendorf
approved these changes
Jun 2, 2020
behlendorf
added
Status: Accepted
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
The macOS kmem implementation uses avl_update() and related functions. These same function exist in the Solaris AVL code but were removed because they were unused. Restore them. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10390 (cherry picked from commit 081de9a)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The macOS kmem implementation uses avl_update() and related functions. These same function exist in the Solaris AVL code but were removed because they were unused. Restore them. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS kmem uses avl_update() and related functions. If other platforms
get "defined but not used" warnings, they may need to be wrapped
in #ifdefs.
This is the first PR to add macOS support to the OpenZFS repo. Will start slow to work out the procedure and find a good balance. Also unsure how upstream platforms handle functions defined but not used.
Be extra picky here, so future PRs will go smoother :)
For a sneak peek of future PRs have a look at;
openzfsonosx/openzfs#4
Motivation and Context
Assuming a macOS port is desired, this is required.
Description
Additional AVL methods lifted directly from illumos.
How Has This Been Tested?
Running zfs-tests on macOS VMs.
Types of changes
Checklist:
Signed-off-by.