Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant includes. #10415

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Remove redundant includes. #10415

merged 1 commit into from
Jun 8, 2020

Conversation

pjd
Copy link
Contributor

@pjd pjd commented Jun 7, 2020

Signed-off-by: Pawel Jakub Dawidek pawel@dawidek.net

Motivation and Context

By removing excessive includes it takes us a small step close to compile this file in userland.

How Has This Been Tested?

The changes was tested by compiling OpenZFS on FreeBSD 13.0-CURRENT (the modified file is FreeBSD-specific). The compiled module was loaded, I imported a pool, performed few basic operations, include 'zfs jail' and 'zfs unjail' defined in the modified file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@pjd
Remove redundant includes.
e0a621b 
Signed-off-by:	Pawel Jakub Dawidek <pawel@dawidek.net>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jun 7, 2020
behlendorf
behlendorf approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Clearly we missed this file when removing unneeded headers.

@behlendorf behlendorf requested a review from a user June 7, 2020 18:31
@codecov
Copy link

codecov bot commented Jun 7, 2020 •
edited
Loading

Codecov Report

Merging #10415 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10415      +/-   ##
==========================================
+ Coverage   79.61%   79.68%   +0.07%     
==========================================
  Files         391      391              
  Lines      123603   123603              
==========================================
+ Hits        98402    98496      +94     
+ Misses      25201    25107      -94
Flag Coverage Δ
#kernel 80.03% <ø> (+0.07%) ⬆️
#user 66.51% <ø> (+0.36%) ⬆️
Impacted Files Coverage Δ
module/lua/lmem.c 83.33% <0.00%> (-4.17%) ⬇️
module/zfs/metaslab.c 94.44% <0.00%> (-1.30%) ⬇️
module/zfs/dmu_traverse.c 96.34% <0.00%> (-0.67%) ⬇️
module/zfs/vdev_removal.c 96.78% <0.00%> (-0.58%) ⬇️
module/os/linux/spl/spl-kmem-cache.c 84.44% <0.00%> (-0.37%) ⬇️
module/zfs/zvol.c 84.06% <0.00%> (-0.34%) ⬇️
module/zfs/dsl_scan.c 85.74% <0.00%> (-0.31%) ⬇️
module/zfs/zap_leaf.c 88.00% <0.00%> (-0.24%) ⬇️
module/os/linux/zfs/zfs_dir.c 82.91% <0.00%> (-0.23%) ⬇️
module/os/linux/zfs/zfs_znode.c 84.93% <0.00%> (-0.23%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf3b16...e0a621b. Read the comment docs.

ghost
ghost approved these changes Jun 8, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👍

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 8, 2020
@behlendorf behlendorf merged commit 77b998f into openzfs:master Jun 8, 2020
BrainSlayer pushed a commit to BrainSlayer/zfs that referenced this pull request Jun 10, 2020
@pjd @BrainSlayer
Remove redundant includes
cf0b161 
By removing excessive includes it takes us a small step close to
compiling this file in userland.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#10415
lundman referenced this pull request in openzfsonosx/openzfs Jun 12, 2020
@pjd @lundman
Remove redundant includes
e9313b3 
By removing excessive includes it takes us a small step close to
compiling this file in userland.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Pawel Jakub Dawidek <pawel@dawidek.net>
Closes #10415
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pjd @jsai20
Remove redundant includes
ce9f688 
By removing excessive includes it takes us a small step close to
compiling this file in userland.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#10415
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@pjd
Remove redundant includes
93e7465 
By removing excessive includes it takes us a small step close to
compiling this file in userland.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#10415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjd @behlendorf @ahrens