Fix typos #10423
Merged
Fix typos #10423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Jun 8, 2020
tests/zfs-tests/tests/functional/cli_root/zfs_get/zfs_get_005_neg.ksh
Outdated
Show resolved
Hide resolved
tests/zfs-tests/tests/functional/cli_root/zfs_inherit/zfs_inherit_002_neg.ksh
Outdated
Show resolved
Hide resolved
ghost
added
the
ghost
approved these changes
Jun 8, 2020
ahrens
approved these changes
Jun 8, 2020
behlendorf
approved these changes
Jun 8, 2020
|
@Gelma thanks! Can you please just address the cstyle warning. |
Ok, I split on two lines. I'm going to send new commit. |
Codecov Report
@@ Coverage Diff @@
## master #10423 +/- ##
==========================================
- Coverage 79.39% 79.30% -0.10%
==========================================
Files 391 391
Lines 123633 123633
==========================================
- Hits 98162 98046 -116
- Misses 25471 25587 +116
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
|
@Gelma one last thing. Can you please squash your changes in to a single commit, add your signed-off-by and then update the PR. |
Thanks a lot. I'm going to upload new version. |
BrainSlayer
pushed a commit
to BrainSlayer/zfs
that referenced
this pull request
Jun 10, 2020
Correct various typos in the comments and tests. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#10423
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 12, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Correct various typos in the comments and tests. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#10423
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Correct various typos in the comments and tests. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#10423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
thanks a lot for your work.
Here a stupid patch about typos.
Thanks a lot,
Gelma