-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD: Kernel module should depend on xdr not krpc after 1300092 #10443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes openzfs#10442 Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions in the xdr module instead of krpc. For FreeBSD 13, the MODULE_DEPEND should be changed to xdr Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Well that's not good 🤔 |
valpackett
added a commit
to DankBSD/ports
that referenced
this pull request
Jun 13, 2020
Manually confirmed this works on head for now. |
Codecov Report
@@ Coverage Diff @@
## master #10443 +/- ##
==========================================
- Coverage 79.58% 79.51% -0.07%
==========================================
Files 391 391
Lines 123872 123872
==========================================
- Hits 98586 98503 -83
- Misses 25286 25369 +83
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Jun 14, 2020
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Jun 14, 2020
ghost
deleted the
openzfs/10442
branch
June 16, 2020 18:51
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 19, 2020
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions in the xdr module instead of krpc. For FreeBSD 13, the MODULE_DEPEND should be changed to xdr Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #10442 Closes #10443
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions in the xdr module instead of krpc. For FreeBSD 13, the MODULE_DEPEND should be changed to xdr Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10442 Closes openzfs#10443
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions in the xdr module instead of krpc. For FreeBSD 13, the MODULE_DEPEND should be changed to xdr Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10442 Closes openzfs#10443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #10442
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions
in the xdr module instead of krpc.
Description
For FreeBSD 13, the MODULE_DEPEND should be changed to xdr
How Has This Been Tested?
Built and loaded correctly on recent 13-current.
Types of changes
Checklist:
Signed-off-by
.