Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Kernel module should depend on xdr not krpc after 1300092 #10443

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2020

Motivation and Context

Closes #10442

Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions
in the xdr module instead of krpc.

Description

For FreeBSD 13, the MODULE_DEPEND should be changed to xdr

How Has This Been Tested?

Built and loaded correctly on recent 13-current.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Closes openzfs#10442

Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions
in the xdr module instead of krpc.

For FreeBSD 13, the MODULE_DEPEND should be changed to xdr

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost
Copy link
Author

ghost commented Jun 12, 2020

Well that's not good 🤔

valpackett added a commit to DankBSD/ports that referenced this pull request Jun 13, 2020
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jun 13, 2020
@ghost
Copy link
Author

ghost commented Jun 13, 2020

Manually confirmed this works on head for now.

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #10443 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10443      +/-   ##
==========================================
- Coverage   79.58%   79.51%   -0.07%     
==========================================
  Files         391      391              
  Lines      123872   123872              
==========================================
- Hits        98586    98503      -83     
- Misses      25286    25369      +83     
Flag Coverage Δ
#kernel 79.97% <ø> (-0.06%) ⬇️
#user 65.75% <ø> (-0.37%) ⬇️
Impacted Files Coverage Δ
module/os/linux/spl/spl-kmem-cache.c 75.58% <0.00%> (-8.50%) ⬇️
module/zfs/vdev_indirect.c 73.66% <0.00%> (-7.00%) ⬇️
module/zfs/bpobj.c 86.86% <0.00%> (-4.29%) ⬇️
module/os/linux/zfs/zio_crypt.c 79.97% <0.00%> (-1.23%) ⬇️
module/zfs/vdev_removal.c 96.45% <0.00%> (-1.03%) ⬇️
cmd/ztest/ztest.c 79.11% <0.00%> (-1.03%) ⬇️
module/zfs/vdev_initialize.c 96.83% <0.00%> (-0.95%) ⬇️
cmd/zed/agents/zfs_mod.c 77.55% <0.00%> (-0.67%) ⬇️
module/zfs/arc.c 89.08% <0.00%> (-0.63%) ⬇️
module/zfs/vdev.c 89.95% <0.00%> (-0.61%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08b993...22858c3. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 14, 2020
@behlendorf behlendorf merged commit 86a0f49 into openzfs:master Jun 16, 2020
@ghost ghost deleted the openzfs/10442 branch June 16, 2020 18:51
lundman referenced this pull request in openzfsonosx/openzfs Jun 19, 2020
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions
in the xdr module instead of krpc.

For FreeBSD 13, the MODULE_DEPEND should be changed to xdr

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #10442 
Closes #10443
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions
in the xdr module instead of krpc.

For FreeBSD 13, the MODULE_DEPEND should be changed to xdr

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10442 
Closes openzfs#10443
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Since https://reviews.freebsd.org/D24408 FreeBSD provides XDR functions
in the xdr module instead of krpc.

For FreeBSD 13, the MODULE_DEPEND should be changed to xdr

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10442 
Closes openzfs#10443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeBSD kernel module should depend on xdr instead of krpc on CURRENT
1 participant