drr_begin: can't forward declare untagged struct #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with Clang++ it does not allow for untagged structs, so struct ddr_begin needs to be declared before the struct that uses it. Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Codecov Report
@@ Coverage Diff @@
## master #10453 +/- ##
==========================================
- Coverage 80.24% 79.60% -0.64%
==========================================
Files 293 393 +100
Lines 83882 123859 +39977
==========================================
+ Hits 67313 98601 +31288
- Misses 16569 25258 +8689
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Jun 15, 2020
behlendorf
added
Status: Code Review Needed
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 19, 2020
When compiling with Clang++ it does not allow for untagged structs, so struct ddr_begin needs to be declared before the struct that uses it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #10453
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
When compiling with Clang++ it does not allow for untagged structs, so struct ddr_begin needs to be declared before the struct that uses it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10453
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
When compiling with Clang++ it does not allow for untagged structs, so struct ddr_begin needs to be declared before the struct that uses it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ doesn't like the way
struct dmu_replay_recordis defined.Motivation and Context
To please Apple's clang++.
Description
When compiling with Clang++ it does not allow for untagged structs, so
struct ddr_begin needs to be declared before the struct that uses it.
../../../../include/sys/zfs_ioctl.h:484:19: error: field has incomplete type
'struct drr_begin'
struct drr_begin zc_begin_record;
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.