zfs_ioctl: saved_poolname can be truncated #10469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10469 +/- ##
==========================================
- Coverage 80.24% 79.21% -1.04%
==========================================
Files 293 393 +100
Lines 83882 123858 +39976
==========================================
+ Hits 67313 98116 +30803
- Misses 16569 25742 +9173
Continue to review full report at Codecov.
|
ahrens
reviewed
Jun 17, 2020
As it uses kmem_strdup() and kmem_strfree() which both rely on strlen() being the same, but saved_poolname can be truncated causing: SPL: kernel memory allocator: buffer freed to wrong cache SPL: buffer was allocated from kmem_alloc_16, SPL: caller attempting free to kmem_alloc_8. SPL: buffer=0xffffff90acc66a38 bufctl=0x0 cache: kmem_alloc_8 Signed-off-by: Jorgen Lundman <lundman@lundman.net>
behlendorf
approved these changes
Jun 17, 2020
ahrens
approved these changes
Jun 17, 2020
behlendorf
added
Status: Accepted
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 19, 2020
As it uses kmem_strdup() and kmem_strfree() which both rely on strlen() being the same, but saved_poolname can be truncated causing: SPL: kernel memory allocator: buffer freed to wrong cache SPL: buffer was allocated from kmem_alloc_16, SPL: caller attempting free to kmem_alloc_8. SPL: buffer=0xffffff90acc66a38 bufctl=0x0 cache: kmem_alloc_8 Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #10469
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
As it uses kmem_strdup() and kmem_strfree() which both rely on strlen() being the same, but saved_poolname can be truncated causing: SPL: kernel memory allocator: buffer freed to wrong cache SPL: buffer was allocated from kmem_alloc_16, SPL: caller attempting free to kmem_alloc_8. SPL: buffer=0xffffff90acc66a38 bufctl=0x0 cache: kmem_alloc_8 Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10469
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
As it uses kmem_strdup() and kmem_strfree() which both rely on strlen() being the same, but saved_poolname can be truncated causing: SPL: kernel memory allocator: buffer freed to wrong cache SPL: buffer was allocated from kmem_alloc_16, SPL: caller attempting free to kmem_alloc_8. SPL: buffer=0xffffff90acc66a38 bufctl=0x0 cache: kmem_alloc_8 Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ioctl handler will at times save the poolname, truncate it, causing free to mismatch size.
Motivation and Context
Freeing with wrong size causes panic on illumos based kmem implementations.
Description
zfs_ioctl.c's ioctl handler will make a copy of
poolname, and truncate it to be only the poolname. It will also calltsd_set()with it, to be freed at a later time. This makes it hard to know the original size. This new code will make a new string fortsd_set()that is exactly the size needed, and keep a strlen copy for local free.How Has This Been Tested?
Many runs of zfs-tests on macOS
Types of changes
Checklist:
Signed-off-by.