Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing cfi frame info in aesni-gcm-x86_64.S #11101

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

AttilaFueloep
Copy link
Contributor

Motivation and Context

While preparing #9749 some .cfi_{start,end}proc directives were missed.

Description

Add the missing ones to bring us in sync with upstream.

See upstream: openssl/openssl@275a048f

How Has This Been Tested?

15 min zloop run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

While preparing openzfs#9749 some .cfi_{start,end}proc directives
were missed. Add the missing ones.

See upstream openssl/openssl@275a048f

Signed-off-by: Attila Fülöp <attila@fueloep.org>
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #11101 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11101      +/-   ##
==========================================
+ Coverage   79.56%   79.64%   +0.07%     
==========================================
  Files         398      398              
  Lines      125754   125754              
==========================================
+ Hits       100060   100153      +93     
+ Misses      25694    25601      -93     
Flag Coverage Δ
kernel 80.37% <ø> (-0.13%) ⬇️
user 65.27% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/os/linux/spl/spl-zlib.c 55.35% <0.00%> (-28.58%) ⬇️
cmd/zvol_id/zvol_id_main.c 76.31% <0.00%> (-5.27%) ⬇️
module/zfs/bpobj.c 86.86% <0.00%> (-3.76%) ⬇️
module/zfs/zio_compress.c 92.72% <0.00%> (-1.82%) ⬇️
module/zfs/zfs_fm.c 86.02% <0.00%> (-1.10%) ⬇️
module/zfs/bptree.c 92.70% <0.00%> (-1.05%) ⬇️
module/zfs/vdev_queue.c 95.28% <0.00%> (-0.89%) ⬇️
module/zfs/dsl_pool.c 94.30% <0.00%> (-0.85%) ⬇️
lib/libzfs/libzfs_changelist.c 84.44% <0.00%> (-0.75%) ⬇️
module/zfs/spa_log_spacemap.c 93.40% <0.00%> (-0.58%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3928ec5...849b48e. Read the comment docs.

@AttilaFueloep
Copy link
Contributor Author

The test failures seem to be due to an infrastructure problem.

remoteFailed: [Failure instance: Traceback (failure with no frames): <class 'twisted.internet.error.ConnectionLost'>: Connection to the other side was lost in a non-clean fashion.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 30, 2020
@behlendorf behlendorf merged commit d9655c5 into openzfs:master Oct 30, 2020
behlendorf pushed a commit that referenced this pull request Oct 30, 2020
While preparing #9749 some .cfi_{start,end}proc directives
were missed. Add the missing ones.

See upstream openssl/openssl@275a048f

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes #11101
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
While preparing openzfs#9749 some .cfi_{start,end}proc directives
were missed. Add the missing ones.

See upstream openssl/openssl@275a048f

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes openzfs#11101
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
While preparing openzfs#9749 some .cfi_{start,end}proc directives
were missed. Add the missing ones.

See upstream openssl/openssl@275a048f

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Attila Fülöp <attila@fueloep.org>
Closes openzfs#11101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants