Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in POSIX mode behavior #11760

Merged
merged 1 commit into from
Mar 20, 2021

Commits on Mar 19, 2021

  1. Fix regression in POSIX mode behavior

    Commit 235a856 introduced a regression in evaluation of POSIX modes
    that require group DENY entries in the internal ZFS ACL. An example
    of such a POSX mode is 007. When write_implies_delete_child is set,
    then ACE_WRITE_DATA is added to `wanted_dirperms` in prior to calling
    zfs_zaccess_common(). This occurs is zfs_zaccess_delete().
    
    Unfortunately, when zfs_zaccess_aces_check hits this particular DENY
    ACE, zfs_groupmember() is checked to determine whether access should be
    denied, and since zfs_groupmember() always returns B_TRUE on Linux and
    so this check is failed, resulting ultimately in EPERM being returned.
    
    Signed-off-by: Andrew Walker <awalker@ixsystems.com>
    anodos325 authored and Ryan Moeller committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    c9cf0bf View commit details
    Browse the repository at this point in the history