dprintf_dnode: strcpy -> strlcpy

[lundman]

Missed a couple of strcpy() in earlier commit, this is only used with --enable-debug.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[lundman]

There is no strscpy() on FreeBSD, macOS or Windows, so in that case you should probably make a zfs_strscpy(), if you wanted to go that far. That does seem outside of this PR though, as there are 2 strcpy()s that missed the change to strlcpy, and is just tidying that up. Lund

…

On Jul 2, 2021, at 14:09, Andy Lavr ***@***.***> wrote: strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding buffer is unbounded. Its safe replacement is strscpy(), as suggested in the deprecated interface — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE3R4CBW4VWETHDGPVOG23TVVCYBANCNFSM47VVOY5Q>.