-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: generate ABI files if changed #12379
Conversation
So commit author can just download them as artifacts and commit. Signed-off-by: George Melikov <mail@gmelikov.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a neat way of handling things! I do notice that the artifact is a .zip that contains a .tar, but at least on my mac the tar is extracted automatically anyway.
It would still be good to improve the portability of the *abi targets for use by downstream projects. I don't really want to have to push everything to github constantly. I do a lot of iterating locally and push to internally hosted git repos and CI systems before pushing to github. But at least this reduces the friction of contributions!
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes openzfs#12379
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes openzfs#12379
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes openzfs#12379
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes openzfs#12379
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #12379
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes openzfs#12379
So commit author can just download them as artifacts and commit. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes openzfs#12379
So commit author can just download them as
artifacts and commit.
Example: https://github.com/gmelikov/zfs/actions/runs/1035256532
Signed-off-by: George Melikov mail@gmelikov.ru
Motivation and Context
Prepare everything for developer in CI.
Minor bonus - nearly identical build env = less unnecessary diff in files.
Description
Generate new ABI files on chekABI fail and present it as artifact, so developer can just download it and
tar -xf abi_files.tar
.How Has This Been Tested?
Manual CI run, downloaded generated files and run
make checkabi
with them on fresh clone of repo.Types of changes