Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable /proc/diskstats for zvols #12440

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Enable /proc/diskstats for zvols #12440

merged 1 commit into from
Aug 5, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #12066. It was observed that /proc/diskstats were not
enabled for zvols.

Description

The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

How Has This Been Tested?

Reading and writing to a zvol and checking the output of cat /proc/diskstats.

cat /proc/diskstats | grep zd0
 230       0 zd0 4194 0 2101344 3120 262144 0 2097152 581157 0 20537 584277 0 0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Enable /proc/diskstats for zvols
cd1b558 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#12066
@behlendorf behlendorf added Component: ZVOL ZFS Volumes Status: Code Review Needed Ready for review and testing labels Jul 27, 2021
@tonynguien tonynguien added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 5, 2021
@tonynguien tonynguien merged commit ae1e40b into openzfs:master Aug 5, 2021
behlendorf added a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@behlendorf
Enable /proc/diskstats for zvols
3298d5c 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12440
Closes openzfs#12066
behlendorf added a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@behlendorf
Enable /proc/diskstats for zvols
1030adf 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12440
Closes openzfs#12066
behlendorf added a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@behlendorf
Enable /proc/diskstats for zvols
3ccac42 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12440
Closes openzfs#12066
behlendorf added a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@behlendorf
Enable /proc/diskstats for zvols
53416da 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12440
Closes openzfs#12066
behlendorf added a commit that referenced this pull request Aug 31, 2021
@behlendorf
Enable /proc/diskstats for zvols
c4a02a6 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12440
Closes #12066
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@behlendorf @tonyhutter
Enable /proc/diskstats for zvols
32a971e 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12440
Closes openzfs#12066
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@behlendorf @rincebrain
Enable /proc/diskstats for zvols
def25f4 
The /proc/diskstats accounting needs to be explicitly enabled
for block devices which do not use multi-queue.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12440
Closes openzfs#12066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonynguien tonynguien tonynguien approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees

@tonynguien tonynguien

Labels
Component: ZVOL ZFS Volumes Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @tonynguien @gmelikov