Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Waiting for zvols to be available #12515

Merged
merged 1 commit into from
Aug 29, 2021
Merged

ZTS: Waiting for zvols to be available #12515

merged 1 commit into from
Aug 29, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

The Fedora CI builder appears to almost always hit at least one false
positive when running the ZTS because a test didn't wait long enough
for a zvol to be available. Try and make this less likely so the Fedora
builder doesn't always fail the CI.

Description

The ZTS block_device_wait helper function should use -e when waiting
for a file to appear since it will be either a block special device
or a symlink. This didn't cause any failures but when a device path
was specified the function would wait longer than needed.

Additionally update the most flaky test cases to pass the file path
to block_device_wait to try and improve the test reliability. The
udev behavior on Fedora in particular can result in frequent false
positives.

How Has This Been Tested?

Locally by running the failing tests in a loop on Fedora 34. This
change does improve their reliability, however at least one other
scenario was observed where for some reason udev on Fedora
would fail entirely to create the needed links. That issue is not
understood or addressed here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
ZTS: Waiting for zvols to be available
771fa89 
The ZTS block_device_wait helper function should use -e when waiting
for a file to appear since it will be either a block special device
or a symlink.  This didn't cause any failures but when a device path
was specified the function would wait longer than needed.

Additionally update the most flakey test cases to pass the file path
to block_device_wait to try and improve the test reliability.  The
udev behavior on Fedora in particular can result in frequent false
positives.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Aug 27, 2021
@rincebrain rincebrain mentioned this pull request Aug 29, 2021
Closed
13 tasks
@jwk404 jwk404 self-assigned this Aug 29, 2021
@jwk404 jwk404 merged commit 70bf547 into openzfs:master Aug 29, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 30, 2021
behlendorf added a commit to behlendorf/zfs that referenced this pull request Aug 30, 2021
@behlendorf
ZTS: Waiting for zvols to be available
3283b25 
The ZTS block_device_wait helper function should use -e when waiting
for a file to appear since it will be either a block special device
or a symlink.  This didn't cause any failures but when a device path
was specified the function would wait longer than needed.

Additionally update the most flakey test cases to pass the file path
to block_device_wait to try and improve the test reliability.  The
udev behavior on Fedora in particular can result in frequent false
positives.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12515
behlendorf added a commit that referenced this pull request Aug 31, 2021
@behlendorf
ZTS: Waiting for zvols to be available
d9f4962 
The ZTS block_device_wait helper function should use -e when waiting
for a file to appear since it will be either a block special device
or a symlink.  This didn't cause any failures but when a device path
was specified the function would wait longer than needed.

Additionally update the most flakey test cases to pass the file path
to block_device_wait to try and improve the test reliability.  The
udev behavior on Fedora in particular can result in frequent false
positives.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12515
behlendorf added a commit to behlendorf/zfs that referenced this pull request Sep 10, 2021
@behlendorf
ZTS: Waiting for zvols to be available
fa8bac2 
This is a follow up patch for PR openzfs#12515 which addresses some
additional ZTS tests which are unreliable are should explicitly
wait for the required zvols to be available.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf mentioned this pull request Sep 10, 2021
Merged
13 tasks
behlendorf added a commit to behlendorf/zfs that referenced this pull request Sep 10, 2021
@behlendorf
ZTS: Waiting for zvols to be available
dbf173c 
This is a follow up patch for PR openzfs#12515 which addresses some
additional ZTS tests which are unreliable are should explicitly
wait for the required zvols to be available.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
behlendorf added a commit that referenced this pull request Sep 13, 2021
@behlendorf
ZTS: Waiting for zvols to be available
695d4ae 
This is a follow up patch for PR #12515 which addresses some
additional ZTS tests which are unreliable are should explicitly
wait for the required zvols to be available.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: @Theo13111
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12553
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@behlendorf @tonyhutter
ZTS: Waiting for zvols to be available
6bb6410 
The ZTS block_device_wait helper function should use -e when waiting
for a file to appear since it will be either a block special device
or a symlink.  This didn't cause any failures but when a device path
was specified the function would wait longer than needed.

Additionally update the most flakey test cases to pass the file path
to block_device_wait to try and improve the test reliability.  The
udev behavior on Fedora in particular can result in frequent false
positives.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12515
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@behlendorf @tonyhutter
ZTS: Waiting for zvols to be available
7816a6b 
This is a follow up patch for PR openzfs#12515 which addresses some
additional ZTS tests which are unreliable are should explicitly
wait for the required zvols to be available.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: @Theo13111
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12553
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@behlendorf @rincebrain
ZTS: Waiting for zvols to be available
8f2c4f1 
The ZTS block_device_wait helper function should use -e when waiting
for a file to appear since it will be either a block special device
or a symlink.  This didn't cause any failures but when a device path
was specified the function would wait longer than needed.

Additionally update the most flakey test cases to pass the file path
to block_device_wait to try and improve the test reliability.  The
udev behavior on Fedora in particular can result in frequent false
positives.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12515
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@behlendorf @rincebrain
ZTS: Waiting for zvols to be available
fe9cd50 
This is a follow up patch for PR openzfs#12515 which addresses some
additional ZTS tests which are unreliable are should explicitly
wait for the required zvols to be available.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: @Theo13111
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwk404 jwk404 jwk404 approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees

@jwk404 jwk404

Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @jwk404 @gmelikov