Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checkstyle workflow env to ubuntu-20.04 #12713

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Update checkstyle workflow env to ubuntu-20.04 #12713

merged 1 commit into from
Nov 2, 2021

Conversation

szubersk
Copy link
Contributor

@szubersk szubersk commented Nov 1, 2021 •
edited
Loading

Motivation and Context

Update checkstyle workflow environment to ubuntu-20.04.
Close #12711

Description

  • checkstyle workflow uses ubuntu-20.04 environment
  • improved mancheck.sh readability

How Has This Been Tested?

make checkstyle
make lint

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

ahrens
ahrens approved these changes Nov 2, 2021
View reviewed changes
module/Makefile.in Show resolved Hide resolved
@szubersk
Update checkstyle workflow env to ubuntu-20.04
b9826ac 
- `checkstyle` workflow uses ubuntu-20.04 environment
- improved `mancheck.sh` readability

Signed-off-by: szubersk <szuberskidamian@gmail.com>
@szubersk
Copy link
Contributor Author

szubersk commented Nov 2, 2021

@ahrens @jwk404 Might I ask for checkstyle workflow run? It's required to have it done before merge.

@szubersk
Copy link
Contributor Author

szubersk commented Nov 2, 2021 •
edited
Loading

Thanks!
Since

You’re not authorized to merge this pull request.

are we ready to merge this PR in?

@jwk404 jwk404 merged commit 6d680e6 into openzfs:master Nov 2, 2021
@szubersk szubersk deleted the szubersk-lint-20 branch November 3, 2021 09:08
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 11, 2021
@szubersk @tonyhutter
Update checkstyle workflow env to ubuntu-20.04
b2e3729 
- `checkstyle` workflow uses ubuntu-20.04 environment
- improved `mancheck.sh` readability

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#12713
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@szubersk @tonyhutter
Update checkstyle workflow env to ubuntu-20.04
0a11bc8 
- `checkstyle` workflow uses ubuntu-20.04 environment
- improved `mancheck.sh` readability

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#12713
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@szubersk @tonyhutter
Update checkstyle workflow env to ubuntu-20.04
8464de1 
- `checkstyle` workflow uses ubuntu-20.04 environment
- improved `mancheck.sh` readability

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#12713
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 8, 2021
@szubersk @tonyhutter
Update checkstyle workflow env to ubuntu-20.04
64e8899 
- `checkstyle` workflow uses ubuntu-20.04 environment
- improved `mancheck.sh` readability

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#12713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@jwk404 jwk404 jwk404 approved these changes

Assignees

@jwk404 jwk404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update checkstyle workflow environment to ubuntu-20.04
3 participants
@szubersk @ahrens @jwk404