Upgrade to libabigail 2.0.0 #12722
Closed
Upgrade to libabigail 2.0.0 #12722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow failed, redoing it. |
This commit should be reverted once openzfs/libabigail-docker#2 is merged and deployed, and new :latest image is tagged. Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
xnox
commented
Nov 8, 2021
| - name: StoreABI | ||
| if: failure() && steps.CheckABI.outcome == 'failure' | ||
| run: | | ||
| sudo docker run -v $(pwd):/source ghcr.io/openzfs/libabigail make storeabi | ||
| sudo docker run -v $(pwd):/source ghcr.io/xnox/libabigail make storeabi | ||
| - name: Prepare artifacts |
There was a problem hiding this comment.
Note above workflow changes are in a stand alone commit, that should be reverted once openzfs/libabigail-docker#2 is merged and deployed.
gmelikov
reviewed
Nov 8, 2021
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
|
Thank you! I'll try to find if there are ready to merge PRs with ABI changes to pass them before this change. Otherwise - I'll merge image after several days. |
|
@xnox I've pushed your PR for image and released it, we're ready to revert second commit here. |
7 tasks
behlendorf
added
Status: Accepted
behlendorf
approved these changes
Nov 10, 2021
|
I've gone ahead and merged just 85b9565 by cherry picking it. Thanks! |
13 tasks
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 10, 2021
Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> Closes openzfs#12722 Closes openzfs#12739
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 10, 2021
Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> Closes openzfs#12722 Closes openzfs#12739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to libabigail 2.0.0
Currently using my own CI image, until openzfs/libabigail-docker#2 is merged
Motivation and Context
Most distributions are upgrading to new libabigail 2.0.0 thus our builds should support the new version of libabigail to maintain ABI checking capability.
Description
Upgrade CI and abi files using libabigail 2.0.0
How Has This Been Tested?
By updating the CI
Types of changes
Checklist:
Signed-off-by.