Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract workflows dependencies #13037

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Extract workflows dependencies #13037

merged 1 commit into from
Feb 7, 2022

Conversation

szubersk
Copy link
Contributor

@szubersk szubersk commented Jan 29, 2022 •
edited
Loading

Motivation and Context

CI changes identified while working on #12928 which don't fit there.
This PR is meant to simplify build environment dependency management and build environment reconstruction by developers.

Description

  • Move build dependencies moved to
    .github/workflows/build-dependencies.txt shared among workflows.

  • Change ubuntu-latest -> ubuntu-20.04 to avoid unexpected
    runner environment updates in zloop workflow.

  • Change ubuntu-20.04 -> ubuntu-latest to track changes in
    runner environment in checkstyle workflow.

  • Kernel buffer is flushed before ZTS invocation to avoid storing
    the same data after each test case run.

  • make is invoked with consistent set of options to reduce
    clutter in logs.

How Has This Been Tested?

GitHub Actions pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@szubersk szubersk marked this pull request as ready for review January 30, 2022 09:57
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Feb 3, 2022
gmelikov
gmelikov suggested changes Feb 4, 2022
View reviewed changes
.github/workflows/checkstyle.yaml Show resolved Hide resolved
.github/workflows/zfs-tests-functional.yml Outdated Show resolved Hide resolved
.github/workflows/zfs-tests-functional.yml Outdated Show resolved Hide resolved
.github/workflows/zfs-tests-sanity.yml Show resolved Hide resolved
@szubersk szubersk mentioned this pull request Feb 5, 2022
Closed
13 tasks
@szubersk szubersk mentioned this pull request Feb 5, 2022
Merged
13 tasks
@szubersk
Extract workflows dependencies
fca8772 
- Move build dependencies moved to
  `.github/workflows/build-dependencies.txt` shared among workflows.

- Change `ubuntu-latest` -> `ubuntu-20.04` to avoid unexpected
  runner environment updates in `zloop` workflow.

- Change `ubuntu-20.04` -> `ubuntu-latest` to track changes in
  runner environment in `checkstyle` workflow.

- Kernel buffer is flushed before ZTS invocation to avoid storing
  the same data after each test case run.

- `make` is invoked with consistent set of options to reduce
  clutter in logs.

Signed-off-by: szubersk <szuberskidamian@gmail.com>
gmelikov
gmelikov approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 7, 2022
@behlendorf behlendorf merged commit add15e9 into openzfs:master Feb 7, 2022
@szubersk szubersk deleted the szubersk-workflows branch February 10, 2022 08:57
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@szubersk @nicman23
Extract workflows dependencies
03453e7 
- Move build dependencies moved to
  `.github/workflows/build-dependencies.txt` shared among workflows.

- Change `ubuntu-latest` -> `ubuntu-20.04` to avoid unexpected
  runner environment updates in `zloop` workflow.

- Change `ubuntu-20.04` -> `ubuntu-latest` to track changes in
  runner environment in `checkstyle` workflow.

- Kernel buffer is flushed before ZTS invocation to avoid storing
  the same data after each test case run.

- `make` is invoked with consistent set of options to reduce
  clutter in logs.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#13037
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@szubersk @nicman23
Extract workflows dependencies
eddb1c4 
- Move build dependencies moved to
  `.github/workflows/build-dependencies.txt` shared among workflows.

- Change `ubuntu-latest` -> `ubuntu-20.04` to avoid unexpected
  runner environment updates in `zloop` workflow.

- Change `ubuntu-20.04` -> `ubuntu-latest` to track changes in
  runner environment in `checkstyle` workflow.

- Kernel buffer is flushed before ZTS invocation to avoid storing
  the same data after each test case run.

- `make` is invoked with consistent set of options to reduce
  clutter in logs.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#13037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szubersk @behlendorf @gmelikov