Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_key_material_https bogus free call #13198

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Fix get_key_material_https bogus free call #13198

merged 1 commit into from
Mar 13, 2022

Conversation

piru
Copy link
Contributor

@piru piru commented Mar 12, 2022 •
edited
Loading

Motivation and Context

This trivial change fixes a bogus free call in get_key_material_https error code path.

Description

The get_key_material_https function error code path had a bogus free call, either resulting in double-free or free of uninitialized pointer.

How Has This Been Tested?

Built on linux amd64 & test suite ran.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly. (doesn't apply, trivial change)
  • I have read the contributing document.
  • I have added tests to cover my changes. (doesn't apply, trivial change)
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

get_key_material_https: removed bogus free() call
409f250 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Signed-off-by: Harry Sintonen <sintonen@iki.fi>
nabijaczleweli
nabijaczleweli approved these changes Mar 12, 2022
View reviewed changes
Copy link
Contributor

@nabijaczleweli nabijaczleweli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruh-roh. and it's uninitialised, too; what was I thinking? how did not one of the reviewers catch this :v

@nabijaczleweli nabijaczleweli mentioned this pull request Mar 12, 2022
Merged
13 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 12, 2022
@behlendorf behlendorf merged commit ebcf12f into openzfs:master Mar 13, 2022
behlendorf pushed a commit that referenced this pull request Mar 17, 2022
@nabijaczleweli
get_key_material_https: removed bogus free() call
0bebcbc 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemia<C5><84>ska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes #13198
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@piru @nicman23
get_key_material_https: removed bogus free() call
d8787dc 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@piru @nicman23
get_key_material_https: removed bogus free() call
bbbee5c 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Aug 30, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
925fbc5 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@piru @lundman
get_key_material_https: removed bogus free() call
9d56731 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
c93cb56 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
53e6223 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
01e743f 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
6371659 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
73350db 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
44dcfa9 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
71a19ac 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
3d98704 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
95020e3 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
0700a3c 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@piru @andrewc12
get_key_material_https: removed bogus free() call
2b5aec5 
The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes openzfs#13198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@nabijaczleweli nabijaczleweli nabijaczleweli approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piru @behlendorf @nabijaczleweli