Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libzfs, zfs: don't NULL-check infallible allocations #13229

Closed
wants to merge 2 commits into from
Closed

libzfs, zfs: don't NULL-check infallible allocations #13229

wants to merge 2 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

How Has This Been Tested?

Not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli
libzfs: don't NULL-check infallible allocations
e391d7f 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
zfs: main: don't NULL-check infallible safe_malloc()
ce28564 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2022
behlendorf pushed a commit that referenced this pull request Mar 30, 2022
@nabijaczleweli @behlendorf
zfs: main: don't NULL-check infallible safe_malloc()
3cfbeb4 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #13229
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Mar 31, 2022
@nabijaczleweli @mcmilk
libzfs: don't NULL-check infallible allocations
aaa20ee 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Mar 31, 2022
@nabijaczleweli @mcmilk
zfs: main: don't NULL-check infallible safe_malloc()
a2fd7e2 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: don't NULL-check infallible allocations
ed1bdc7 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
zfs: main: don't NULL-check infallible safe_malloc()
5e67fb2 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: don't NULL-check infallible allocations
f9646c1 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
zfs: main: don't NULL-check infallible safe_malloc()
d38affa 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@nabijaczleweli @lundman
libzfs: don't NULL-check infallible allocations
178e661 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@nabijaczleweli @lundman
zfs: main: don't NULL-check infallible safe_malloc()
c26a80b 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@nabijaczleweli @beren12
libzfs: don't NULL-check infallible allocations
5552be3 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@nabijaczleweli @beren12
zfs: main: don't NULL-check infallible safe_malloc()
36f85b3 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
c4a1b6e 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
e92ad4e 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
1843dac 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
d2b8961 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
e30fff1 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
1a30cbc 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
85ac31d 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
f98efd0 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
c7ad5a8 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
c2a37cb 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
af25733 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
1ce663b 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
7539417 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
78aa1f3 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
311b6e9 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
0f43e37 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
c0f4827 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
9e30b8e 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
97c029d 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
475f4c9 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
664a46a 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
4d9e137 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
d980c3c 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
a80a01c 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
755fd79 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
7ddbf16 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
d5668d4 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
366e079 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: don't NULL-check infallible allocations
f06cb66 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
zfs: main: don't NULL-check infallible safe_malloc()
2a95a33 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@jwk404 jwk404

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @behlendorf @jwk404