Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: Use the correct version-release information in dependencies #13489

Merged
merged 1 commit into from
May 24, 2022
Merged

rpm: Use the correct version-release information in dependencies #13489

merged 1 commit into from
May 24, 2022

Conversation

Conan-Kudo
Copy link
Contributor

@Conan-Kudo Conan-Kudo commented May 21, 2022 •
edited
Loading

Motivation and Context

This fixes an issue in which it was possible to mix subpackages from different builds of the same version. This was undesirable, especially when testing patches that change code across multiple subpackages. By making this change, it will no longer be possible to have a mixture for userspace components.

Description

This changes the dependency strings for subpackages within this package so that they're dependent on the exact build produced from this spec file.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@Conan-Kudo Conan-Kudo changed the title rpm: Fix dependency strings to us correct version-release information rpm: Fix dependency strings to use the correct version-release information May 21, 2022
@Conan-Kudo Conan-Kudo changed the title rpm: Fix dependency strings to use the correct version-release information rpm: Use the correct version-release information in dependencies May 21, 2022
tonyhutter
tonyhutter reviewed May 24, 2022
View reviewed changes
rpm/generic/zfs.spec.in Outdated Show resolved Hide resolved
@Conan-Kudo
rpm: Use the correct version-release information in dependencies
83c720e 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Signed-off-by: Neal Gompa <ngompa@datto.com>
@behlendorf behlendorf added Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested) labels May 24, 2022
@behlendorf behlendorf merged commit 4dc1c8a into openzfs:master May 24, 2022
@Conan-Kudo Conan-Kudo deleted the spec-dep-fixes branch May 24, 2022 21:27
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@Conan-Kudo @nicman23
rpm: Use the correct version-release information in dependencies
b682222 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@Conan-Kudo @nicman23
rpm: Use the correct version-release information in dependencies
1ae6f68 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 12, 2022
@Conan-Kudo @lundman
rpm: Use the correct version-release information in dependencies
71e98aa 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2022
@Conan-Kudo @tonyhutter
rpm: Use the correct version-release information in dependencies
e1b49e3 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@Conan-Kudo @beren12
rpm: Use the correct version-release information in dependencies
8703af6 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
5e9fddc 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
f34490b 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
66cbe2b 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
feebccd 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
73bc7ed 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
423b2d0 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
ce29751 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
81720c5 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
8a279d9 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
2db2e96 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
2a35814 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
0903a59 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
9d21845 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
2c6011e 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
b9c8127 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
1784279 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
0c49ecb 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
ed57222 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
b01b9de 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
aed28d6 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
cf36990 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
b7adcad 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
f2de47a 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
73e42db 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
f5b6936 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@Conan-Kudo @andrewc12
rpm: Use the correct version-release information in dependencies
a2837e9 
This tightly links the subpackages together and ensures that everything
is upgraded together.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes openzfs#13489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Conan-Kudo @behlendorf @tonyhutter