-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of IBM Power8 machines (ISA 2.07) #14576
Conversation
Please add the followings to fix #13741 (comment): diff --git a/module/icp/algs/sha2/sha512_impl.c b/module/icp/algs/sha2/sha512_impl.c
index b6341f6..8e1dfab 100644
--- a/module/icp/algs/sha2/sha512_impl.c
+++ b/module/icp/algs/sha2/sha512_impl.c
@@ -131,14 +131,14 @@ const sha512_ops_t sha512_ppc_impl = {
.name = "ppc"
};
-static boolean_t sha512_have_vsx(void)
+static boolean_t sha512_have_isa207(void)
{
- return (kfpu_allowed() && zfs_vsx_available());
+ return (kfpu_allowed() && zfs_isa207_available());
}
TF(zfs_sha512_power8, tf_sha512_power8);
const sha512_ops_t sha512_power8_impl = {
- .is_supported = sha512_have_vsx,
+ .is_supported = sha512_have_isa207,
.transform = tf_sha512_power8,
.name = "power8"
}; |
An IBM POWER7 system with Power ISA 2.06 tried to execute zfs_sha256_power8() - which should only be run on ISA 2.07 machines. The detection is implemented via the zfs_isa207_available() call, but this check was not used. This pull request will fix this. Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Low-power <msl0000023508@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed to work on both POWER7 and POWER8 machines in my environment.
Could you post the output of |
POWER7 machine:
POWER8 machine:
|
An IBM POWER7 system with Power ISA 2.06 tried to execute zfs_sha256_power8() - which should only be run on ISA 2.07 machines. The detection is implemented via the zfs_isa207_available() call, but this check was not used. This pull request will fix this. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Low-power <msl0000023508@gmail.com> Closes openzfs#14576
An IBM POWER7 system with Power ISA 2.06 tried to execute zfs_sha256_power8() - which should only be run on ISA 2.07 machines. The detection is implemented via the zfs_isa207_available() call, but this check was not used. This pull request will fix this. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Low-power <msl0000023508@gmail.com> Closes openzfs#14576
An IBM POWER7 system with Power ISA 2.06 tried to execute
zfs_sha256_power8()
- which should only be run on ISA 2.07 machines.The detection is implemented via the
zfs_isa207_available()
call, but this check was not used.This pull request will fix this.
Motivation and Context
#13741 (comment)
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.