Fix memory leak in ztest #14583
Merged
Fix memory leak in ztest #14583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is tripping LeakSanitizer, which causes zloop test failures on pull requests. Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
mcmilk
approved these changes
Mar 6, 2023
| return; | ||
| } | ||
|
|
13 tasks
|
The Fedora buildbot failure is #14584. |
behlendorf
approved these changes
Mar 6, 2023
13 tasks
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Mar 13, 2023
This is tripping LeakSanitizer, which causes zloop test failures on pull requests. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes openzfs#14583
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 16, 2023
This is tripping LeakSanitizer, which causes zloop test failures on pull requests. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes openzfs#14583
datacore-rm
pushed a commit
to DataCoreSoftware/openzfs
that referenced
this pull request
Aug 14, 2023
This is tripping LeakSanitizer, which causes zloop test failures on pull requests. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes openzfs#14583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is tripping LeakSanitizer, which causes zloop test failures on pull requests.
https://github.com/openzfs/zfs/actions/runs/4339196990
https://github.com/openzfs/zfs/actions/runs/4328310768
Description
Add a missing
umem_free()to an error path inztest_dmu_object_alloc_free()and zero the pointer to it. Inspection of the code reveals that nothing uses thezd->zd_odpointer after callingztest_dmu_object_alloc_free(), so this should be fine.How Has This Been Tested?
The buildbot can test it.
Types of changes
Checklist:
Signed-off-by.