-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine special_small_blocks property validation #14811
Merged
behlendorf
merged 1 commit into
openzfs:master
from
don-brady:special_small_blocks_create
May 12, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
tests/zfs-tests/tests/functional/alloc_class/alloc_class_014_neg.ksh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#!/bin/ksh -p | ||
|
||
# | ||
# This file and its contents are supplied under the terms of the | ||
# Common Development and Distribution License ("CDDL"), version 1.0. | ||
# You may only use this file in accordance with the terms of version | ||
# 1.0 of the CDDL. | ||
# | ||
# A full copy of the text of the CDDL should have accompanied this | ||
# source. A copy of the CDDL is also available via the Internet at | ||
# http://www.illumos.org/license/CDDL. | ||
# | ||
|
||
. $STF_SUITE/tests/functional/alloc_class/alloc_class.kshlib | ||
|
||
# | ||
# DESCRIPTION: | ||
# Setting the special_small_blocks property greater than recordsize fails. | ||
# | ||
|
||
verify_runnable "global" | ||
|
||
claim="Setting the special_small_blocks property greater than recordsize fails" | ||
|
||
log_assert $claim | ||
log_onexit cleanup | ||
log_must disk_setup | ||
|
||
for size in 512 4096 32768 131072 524288 1048576 | ||
do | ||
let bigger=$size*2 | ||
log_mustnot zpool create -O recordsize=$size \ | ||
-O special_small_blocks=$bigger \ | ||
$TESTPOOL raidz $ZPOOL_DISKS special mirror \ | ||
$CLASS_DISK0 $CLASS_DISK1 | ||
done | ||
|
||
log_pass $claim |
45 changes: 45 additions & 0 deletions
45
tests/zfs-tests/tests/functional/alloc_class/alloc_class_015_pos.ksh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
#!/bin/ksh -p | ||
|
||
# | ||
# This file and its contents are supplied under the terms of the | ||
# Common Development and Distribution License ("CDDL"), version 1.0. | ||
# You may only use this file in accordance with the terms of version | ||
# 1.0 of the CDDL. | ||
# | ||
# A full copy of the text of the CDDL should have accompanied this | ||
# source. A copy of the CDDL is also available via the Internet at | ||
# http://www.illumos.org/license/CDDL. | ||
# | ||
|
||
. $STF_SUITE/tests/functional/alloc_class/alloc_class.kshlib | ||
|
||
# | ||
# DESCRIPTION: | ||
# Can set special_small_blocks property less than or equal to recordsize. | ||
# | ||
|
||
verify_runnable "global" | ||
|
||
claim="Can set special_small_blocks property less than or equal to recordsize" | ||
|
||
log_assert $claim | ||
log_onexit cleanup | ||
log_must disk_setup | ||
|
||
for size in 8192 32768 131072 524288 1048576 | ||
do | ||
let smaller=$size/2 | ||
log_must zpool create -O recordsize=$size \ | ||
-O special_small_blocks=$smaller \ | ||
$TESTPOOL raidz $ZPOOL_DISKS special mirror \ | ||
$CLASS_DISK0 $CLASS_DISK1 | ||
log_must zpool destroy -f "$TESTPOOL" | ||
|
||
log_must zpool create -O recordsize=$size \ | ||
-O special_small_blocks=$size \ | ||
$TESTPOOL raidz $ZPOOL_DISKS special mirror \ | ||
$CLASS_DISK0 $CLASS_DISK1 | ||
log_must zpool destroy -f "$TESTPOOL" | ||
done | ||
|
||
log_pass $claim |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to add these new tests to
tests/zfs-tests/tests/Makefile.am
.