Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zed: Fix zed ASSERT on slot power cycle #15084

Merged
merged 1 commit into from
Jul 21, 2023
Merged

zed: Fix zed ASSERT on slot power cycle #15084

merged 1 commit into from
Jul 21, 2023

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented Jul 20, 2023 •
edited
Loading

Motivation and Context

Fix ZED assert

Description

We would see zed assert on one of our systems if we powered off a slot. Further examination showed it returning a zfs_retire_recv() with a GUID of 0, which in turn would return a NULL nvlist. Add in a check for a zero GUID to prevent this.

How Has This Been Tested?

Manually verified this fixed the assertion.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 20, 2023
@tonyhutter
zed: Fix zed ASSERT on slot power cycle
d748db4 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 21, 2023
@behlendorf behlendorf merged commit ab0b039 into openzfs:master Jul 21, 2023
18 of 19 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jul 21, 2023
@tonyhutter @behlendorf
zed: Fix zed ASSERT on slot power cycle
1784f3f 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#15084
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jul 21, 2023
@tonyhutter @behlendorf
zed: Fix zed ASSERT on slot power cycle
9588581 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#15084
behlendorf pushed a commit that referenced this pull request Jul 21, 2023
@tonyhutter @behlendorf
zed: Fix zed ASSERT on slot power cycle
8c81c0b 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #15084
behlendorf pushed a commit that referenced this pull request Jul 24, 2023
@tonyhutter @behlendorf
zed: Fix zed ASSERT on slot power cycle
846a4cc 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #15084
ofaaland pushed a commit to LLNL/zfs that referenced this pull request Aug 29, 2023
@tonyhutter @defaziogiancarlo
zed: Fix zed ASSERT on slot power cycle
a849cfc 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#15084
Signed-off-by: Gian-Carlo DeFazio <defazio1@llnl.gov>
(cherry-picked from commit ab0b039)
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@tonyhutter @lundman
zed: Fix zed ASSERT on slot power cycle
371927f 
We would see zed assert on one of our systems if we powered off a
slot.  Further examination showed zfs_retire_recv() was reporting
a GUID of 0, which in turn would return a NULL nvlist.  Add
in a check for a zero GUID.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#15084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyhutter @behlendorf