Add zfs_prepare_disk script for disk firmware install #15243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyhutter
force-pushed
the
newdisk2
branch
6 times, most recently
from
90d18bd
to
78e8c1a
Compare
tonyhutter
changed the title
tonyhutter
force-pushed
the
newdisk2
branch
from
78e8c1a
to
d4327fe
Compare
behlendorf
reviewed
Sep 12, 2023
tonyhutter
force-pushed
the
newdisk2
branch
from
d4327fe
to
8961ebb
Compare
|
@behlendorf I included your fixes in my latest push, however I see some FreeBSD build errors and still need to deal with those |
tonyhutter
force-pushed
the
newdisk2
branch
14 times, most recently
from
ffaeb57
to
50b91f3
Compare
behlendorf
approved these changes
Sep 20, 2023
tonyhutter
force-pushed
the
newdisk2
branch
from
50b91f3
to
3dd2b12
Compare
Have libzfs call a special `zfs_prepare_disk` script before a disk is included into the pool. The user can edit this script to add things like a disk firmware update or a disk health check. Use of the script is totally optional. See the zfs_prepare_disk manpage for full details. Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter
force-pushed
the
newdisk2
branch
from
3dd2b12
to
c2411bd
Compare
behlendorf
added
Status: Accepted
defaziogiancarlo
pushed a commit
to LLNL/zfs
that referenced
this pull request
Sep 22, 2023
Have libzfs call a special `zfs_prepare_disk` script before a disk is included into the pool. The user can edit this script to add things like a disk firmware update or a disk health check. Use of the script is totally optional. See the zfs_prepare_disk manpage for full details. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#15243
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Nov 20, 2023
Have libzfs call a special `zfs_prepare_disk` script before a disk is included into the pool. The user can edit this script to add things like a disk firmware update or a disk health check. Use of the script is totally optional. See the zfs_prepare_disk manpage for full details. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#15243
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Have libzfs call a special `zfs_prepare_disk` script before a disk is included into the pool. The user can edit this script to add things like a disk firmware update or a disk health check. Use of the script is totally optional. See the zfs_prepare_disk manpage for full details. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#15243
behlendorf
pushed a commit
that referenced
this pull request
Feb 13, 2024
Have libzfs call a special `zfs_prepare_disk` script before a disk is included into the pool. The user can edit this script to add things like a disk firmware update or a disk health check. Use of the script is totally optional. See the zfs_prepare_disk manpage for full details. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes #15243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add a way to update disk firmware before including a disk in pool.
Description
Have libzfs call a special
zfs_prepare_diskscript before a disk is included into the pool. The user can edit this script to add things like a disk firmware update or a disk health check. Use of the script is totally optional. See thezfs_prepare_diskmanpage for full details.This also reformats the code so that both
zfs_prepare_diskand thezpool.d/scripts use similar codepaths.How Has This Been Tested?
Created a pool on a VM and saw script run. Added a disk and saw script get run. Replaced a disk and saw script get run. Tested autoreplace.
Types of changes
Checklist:
Signed-off-by.