Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix verify_fs_mount in delegate_common.kshlib #15376

Merged
merged 1 commit into from
Oct 10, 2023
Merged

ZTS: Fix verify_fs_mount in delegate_common.kshlib #15376

merged 1 commit into from
Oct 10, 2023

Conversation

usaleem-ix
Copy link
Contributor

@usaleem-ix usaleem-ix commented Oct 9, 2023 •
edited
Loading

Motivation and Context

verify_fs_mount in delegate_common.kshlib expects the dataset to remain unmounted after updating the mountpoint property. zfs_allow_010_pos test case fails because of this.

Description

This commit updates verify_fs_mount and uses nomount parameter for zfs set to update the mountpoint property without mounting the dataset.

This fixes the zfs_allow_010_pos test case, which was failing on FreeBSD after the behavior update in setting the mountpoint property.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@usaleem-ix
ZTS: Fix verify_fs_mount in delegate_common.kshlib
0e4e618 
verify_fs_mount expects the dataset to remain unmounted after
updating the mountpoint property in delegate_common.kshlib.

This commit updates verify_fs_mount and uses nomount parameter
for zfs set to update the mountpoint property without mounting
the dataset.

This fixes the zfs_allow_010_pos test case, which was failing on
FreeBSD after the behavior update in setting the mountpoint
property.

Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 9, 2023
@behlendorf behlendorf merged commit 250349f into openzfs:master Oct 10, 2023
23 of 26 checks passed
behlendorf added a commit to behlendorf/zfs that referenced this pull request Oct 10, 2023
@behlendorf
ZTS: Remove zfs_allow_010_pos expection for FreeBSD
d99fbdf 
This issue should now be address by PR openzfs#15376 and the exception
for this test case be removed.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf mentioned this pull request Oct 10, 2023
Merged
13 tasks
behlendorf added a commit that referenced this pull request Oct 10, 2023
@behlendorf
ZTS: Remove zfs_allow_010_pos expection for FreeBSD
483ccf0 
This issue should now be address by PR #15376 and the exception
for this test case be removed.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by:  Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #15382
behlendorf pushed a commit that referenced this pull request Oct 11, 2023
@usaleem-ix @behlendorf
ZTS: Fix verify_fs_mount in delegate_common.kshlib
9fa06c5 
verify_fs_mount expects the dataset to remain unmounted after
updating the mountpoint property in delegate_common.kshlib.

This commit updates verify_fs_mount and uses nomount parameter
for zfs set to update the mountpoint property without mounting
the dataset.

This fixes the zfs_allow_010_pos test case, which was failing on
FreeBSD after the behavior update in setting the mountpoint
property.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes #15376
behlendorf added a commit that referenced this pull request Oct 11, 2023
@behlendorf
ZTS: Remove zfs_allow_010_pos expection for FreeBSD
75a7740 
This issue should now be address by PR #15376 and the exception
for this test case be removed.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by:  Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #15382
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@usaleem-ix @lundman
ZTS: Fix verify_fs_mount in delegate_common.kshlib
53693a7 
verify_fs_mount expects the dataset to remain unmounted after
updating the mountpoint property in delegate_common.kshlib.

This commit updates verify_fs_mount and uses nomount parameter
for zfs set to update the mountpoint property without mounting
the dataset.

This fixes the zfs_allow_010_pos test case, which was failing on
FreeBSD after the behavior update in setting the mountpoint
property.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#15376
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@behlendorf @lundman
ZTS: Remove zfs_allow_010_pos expection for FreeBSD
e9b284d 
This issue should now be address by PR openzfs#15376 and the exception
for this test case be removed.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by:  Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#15382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usaleem-ix @behlendorf @amotin