Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zpool_import_hostid_changed* tests to Linux runfile #15377

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Update the default tests to reflect what is expected in the CI.

Description

Relocate the zpool_import_hostid_changed* test cases to the Linux
runfile until these tests are modified to run cleanly on FreeBSD.

How Has This Been Tested?

Will be testing by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking c Relocate the zpool_import_hostid_changed* test cases to the Linux
    runfile until these tests are modified to run cleanly on FreeBSD.
    hange which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 9, 2023
Relocate the zpool_import_hostid_changed* test cases to the Linux
runfile until these tests are modified to run cleanly on FreeBSD.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@amotin
Copy link
Member

amotin commented Oct 9, 2023

Not that I am opposing, but they may stuck that way forever. ;)

@behlendorf
Copy link
Contributor Author

This is true. Hopefully someone will take a look at updating these sooner rather than latter.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 9, 2023
@behlendorf behlendorf merged commit 954a380 into openzfs:master Oct 10, 2023
21 of 26 checks passed
behlendorf added a commit that referenced this pull request Oct 11, 2023
Relocate the zpool_import_hostid_changed* test cases to the Linux
runfile until these tests are modified to run cleanly on FreeBSD.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #15377
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
Relocate the zpool_import_hostid_changed* test cases to the Linux
runfile until these tests are modified to run cleanly on FreeBSD.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#15377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants