Extend import_progress kstat with a notes field #15539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotin
reviewed
Nov 17, 2023
behlendorf
reviewed
Nov 17, 2023
don-brady
force-pushed
the
import-status-notes
branch
from
082ac26
to
c39ecc7
Compare
|
Updated to address review feedback |
behlendorf
reviewed
Nov 27, 2023
don-brady
force-pushed
the
import-status-notes
branch
from
c39ecc7
to
517fb73
Compare
behlendorf
reviewed
Nov 28, 2023
don-brady
force-pushed
the
import-status-notes
branch
from
517fb73
to
a43cb21
Compare
behlendorf
approved these changes
Nov 29, 2023
amotin
reviewed
Nov 29, 2023
don-brady
force-pushed
the
import-status-notes
branch
from
a43cb21
to
9f58b84
Compare
|
Another pass to address Alexander's feedback. |
amotin
reviewed
Nov 30, 2023
tests/zfs-tests/tests/functional/cli_root/zpool_import/zpool_import_status.ksh
Outdated
Show resolved
Hide resolved
tests/zfs-tests/tests/functional/cli_root/zpool_import/zpool_import_status.ksh
Outdated
Show resolved
Hide resolved
don-brady
force-pushed
the
import-status-notes
branch
from
9f58b84
to
a64bbab
Compare
amotin
reviewed
Nov 30, 2023
tests/zfs-tests/tests/functional/cli_root/zpool_import/zpool_import_status.ksh
Outdated
Show resolved
Hide resolved
Detail the import progress of log spacemaps as they can take a very long time. Also grab the spa_note() messages to, as they provide insight into what is happening Sponsored-By: OpenDrives Inc. Sponsored-By: Klara Inc. Co-authored-by: Don Brady <don.brady@klarasystems.com> Signed-off-by: Don Brady <don.brady@klarasystems.com>
don-brady
force-pushed
the
import-status-notes
branch
from
a64bbab
to
9189ed9
Compare
|
Fixed Linux-specific date format |
behlendorf
approved these changes
Dec 1, 2023
behlendorf
added
Status: Accepted
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Detail the import progress of log spacemaps as they can take a very long time. Also grab the spa_note() messages to, as they provide insight into what is happening Sponsored-By: OpenDrives Inc. Sponsored-By: Klara Inc. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Don Brady <don.brady@klarasystems.com> Co-authored-by: Allan Jude <allan@klarasystems.com> Closes openzfs#15539
tonyhutter
pushed a commit
that referenced
this pull request
May 2, 2024
Detail the import progress of log spacemaps as they can take a very long time. Also grab the spa_note() messages to, as they provide insight into what is happening Sponsored-By: OpenDrives Inc. Sponsored-By: Klara Inc. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Don Brady <don.brady@klarasystems.com> Co-authored-by: Allan Jude <allan@klarasystems.com> Closes #15539
allanjude
pushed a commit
to KlaraSystems/zfs
that referenced
this pull request
May 21, 2024
Detail the import progress of log spacemaps as they can take a very long time. Also grab the spa_note() messages to, as they provide insight into what is happening Sponsored-By: OpenDrives Inc. Sponsored-By: Klara Inc. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Don Brady <don.brady@klarasystems.com> Co-authored-by: Allan Jude <allan@klarasystems.com> Closes openzfs#15539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As reported and observed in other issues, the time for an unclean pool import can take a long time. It would be nice to be able to observe where the time is being spent for imports that are taking a long time to complete.
Description
This change adds more details to the existing
import_progresskstat in the form of import progress notes.This information is also logged to the zfs debug messages.
Sponsored-By: OpenDrives Inc.
Sponsored-By: Klara Inc.
Here's an example of output from the zfs debug messages:
How Has This Been Tested?
Added a new ZTS test,
zpool_import_status, to verify the kstat and zfs dbgmsg outputs.Also ran
ztestand performed some manual pool import testingTypes of changes
Checklist:
Signed-off-by.