Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only provide execvpe(3) when needed #15609

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

brooksdavis
Copy link
Contributor

Check for the existence of execvpe(3) and only provide the FreeBSD compat version if required.

Motivation and Context

OpenZFS currently unconditionally defines execvpe in the SPL on FreeBSD. I'd like to add it (actually just expose it) on FreeBSD.

Description

Enable an autoconf check for execvpe and check for HAVE_EXECVPE before declared if defining it.

Technically it's a library ABI change on FreeBSD, but probably not in a way that matters?

How Has This Been Tested?

Trivial and it compiles.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 29, 2023
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and straight forward. I'd only suggest adding a comment to lib/libzfs/os/freebsd/libzfs_compat.c mentioning in what version of FreeBSD execvpe() was added.

Check for the existence of execvpe(3) and only provide the FreeBSD
compat version if required.

Signed-off-by:	Brooks Davis <brooks.davis@sri.com>
@brooksdavis
Copy link
Contributor Author

I've added a note claiming it will be added in FreeBSD 15. I might merge it to earlier versions, but it depends how many more issues like this one I run into.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 30, 2023
@behlendorf behlendorf merged commit 3e4bef5 into openzfs:master Dec 1, 2023
25 of 26 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
Check for the existence of execvpe(3) and only provide the FreeBSD
compat version if required.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Brooks Davis <brooks.davis@sri.com>
Closes openzfs#15609
robn pushed a commit to robn/zfs that referenced this pull request Jul 18, 2024
Check for the existence of execvpe(3) and only provide the FreeBSD
compat version if required.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Brooks Davis <brooks.davis@sri.com>
Closes openzfs#15609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants