Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRT: Change brt_pending_tree sorting order #15954

Merged
merged 1 commit into from
Mar 21, 2024

Commits on Mar 2, 2024

  1. BRT: Change brt_pending_tree sorting order

    It does not look important how exactly brt_pending_tree is sorted.
    When cloning large file, it is quite likely that all of its blocks
    have identical physical birth times, so comparing them first does
    not provide useful entropy, while accesses additional cache line.
    In most cases combination of vdev and offset provides unique result
    and physical birth time comparison is not even needed.  Meanwhile,
    when traversing the tree inside brt_pending_apply(), it can be
    beneficial for dbuf cache and CPU cache hits to group processing
    by vdev and so by the per-VDEV BRT ZAPs.
    
    Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
    Sponsored by:	iXsystems, Inc.
    amotin committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    f8d8da0 View commit details
    Browse the repository at this point in the history