udev: correctly handle partition #16 and later #15970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a zvol has more than 15 partitions, the minor device number exhausts the slot count reserved for partitions next to the zvol itself. As a result, the minor number cannot be used to determine the partition number for the higher partition, and doing so results in wrong named symlinks being generated by udev. Since the partition number is encoded in the block device name anyway, let's just extract it from there instead. Fixes: openzfs#15904 Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
As a reference, Amazon ships their Amazon Linux 2023 KVM disk image with partition ids 127 and 128. |
|
FWIW, I am fairly sure the test failure is not this PRs fault :) |
tonyhutter
approved these changes
Mar 6, 2024
mcmilk
approved these changes
Mar 6, 2024
|
Hi there, do we have any idea when this will be merged in? Or if it's merged in a separate PR, could we link it to this one? I'm currently having this exact problem. |
|
I don't know about the timeline, but the fix is entirely in the udev helper, so if you know how to build ZFS, then it's fairly easy to build and deploy ;) |
behlendorf
approved these changes
Mar 21, 2024
@PaulArandjelovic the commit will be in our upcoming 2.2.4 release: #16107 |
tonyhutter
pushed a commit
that referenced
this pull request
May 2, 2024
If a zvol has more than 15 partitions, the minor device number exhausts the slot count reserved for partitions next to the zvol itself. As a result, the minor number cannot be used to determine the partition number for the higher partition, and doing so results in wrong named symlinks being generated by udev. Since the partition number is encoded in the block device name anyway, let's just extract it from there instead. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes #15904 Closes #15970
datty
pushed a commit
to datty/zfsonlinux
that referenced
this pull request
Jun 13, 2024
If a zvol has more than 15 partitions, the minor device number exhausts the slot count reserved for partitions next to the zvol itself. As a result, the minor number cannot be used to determine the partition number for the higher partition, and doing so results in wrong named symlinks being generated by udev. Since the partition number is encoded in the block device name anyway, let's just extract it from there instead. For upstream issue and PR discussion see: openzfs/zfs#15970 openzfs/zfs#15904 Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
If a zvol has more than 15 partitions, the minor device number exhausts the slot count reserved for partitions next to the zvol itself. As a result, the minor number cannot be used to determine the partition number for the higher partition, and doing so results in wrong named symlinks being generated by udev. Since the partition number is encoded in the block device name anyway, let's just extract it from there instead. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes openzfs#15904 Closes openzfs#15970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If a zvol has more than 15 partitions, the minor device number exhausts the slot count reserved for partitions next to the zvol itself. As a result, the minor number cannot be used to determine the partition number for the higher partition, and doing so results in wrong named symlinks being generated by udev.
Fixes: #15904
Description
Since the partition number is encoded in the block device name anyway, let's just extract it from there instead.
How Has This Been Tested?
Created a zvol with more than 15 partitions. Compared generated named symlinks with and without the fix.
Types of changes
Checklist:
Signed-off-by.