Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return NULL at end of send_progress_thread #16074

Merged
merged 1 commit into from
Apr 10, 2024
Merged

return NULL at end of send_progress_thread #16074

merged 1 commit into from
Apr 10, 2024

Conversation

calccrypto
Copy link
Contributor

@calccrypto calccrypto commented Apr 9, 2024 •
edited
Loading

send_progress_thread returns void *, but does not have a return.

Motivation and Context

This was discovered when compiling with -g3 -O0.

Description

Added return (NULL); to the end of send_progress_thread.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@calccrypto
return NULL at end of send_progress_thread
dab80d6 
Signed-off-by: Jason Lee <jasonlee@lanl.gov>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 9, 2024
@behlendorf behlendorf merged commit e5ddecd into openzfs:master Apr 10, 2024
25 checks passed
@calccrypto calccrypto deleted the return_null branch April 10, 2024 22:03
tonyhutter pushed a commit that referenced this pull request May 2, 2024
@calccrypto @tonyhutter
return NULL at end of send_progress_thread
97889c0 
Reviewed-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jason Lee <jasonlee@lanl.gov>
Closes #16074
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@calccrypto @lundman
return NULL at end of send_progress_thread
81f59b9 
Reviewed-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jason Lee <jasonlee@lanl.gov>
Closes openzfs#16074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@robn robn robn approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calccrypto @robn @behlendorf