Add newline to two zpool messages #16113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Troisi <sethtroisi@google.com>
|
Thanks @behlendorf for the quick review and merge. Makes me like ZFS even more :) |
tonyhutter
pushed a commit
that referenced
this pull request
May 2, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Seth Troisi <sethtroisi@google.com> Closes #16113
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Seth Troisi <sethtroisi@google.com> Closes openzfs#16113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes two log messages without terminating newlines where my terminal would end up in weird places.
Description
Adds newline to the end of two zpool messages
How Has This Been Tested?
I ran
./scripts/zfs-tests.sh -vx16 tests failed, I reran without my change and the same 16 tests fail. I added a few missing utilities and got the number of tests with results other than PASS down to 6 (all related to l2arc) I plan to investigate but looking at the error logs I doubt my change to a log message broke them.Types of changes
Checklist:
Signed-off-by.