Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC: Fixes for gcc 14 on Fedora 40 #16125

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented Apr 24, 2024

Motivation and Context

Build ZFS on GCC 14

Description

How Has This Been Tested?

Test built

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This was referenced Apr 24, 2024
lib/libuutil/uu_list.c Outdated Show resolved Hide resolved
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 24, 2024
@tonyhutter tonyhutter force-pushed the fedora40-gcc branch 3 times, most recently from 925a1e8 to 431b8d8 Compare April 24, 2024 22:46
lib/libuutil/uu_list.c Outdated Show resolved Hide resolved
lib/libuutil/uu_list.c Outdated Show resolved Hide resolved
- Workaround dangling pointer in uu_list.c (openzfs#16124)
- Fix calloc() transposed arguments in zpool_vdev_os.c
- Make some temp variables unsigned to prevent triggering a
  '-Werror=alloc-size-larger-than' error.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Issue: openzfs#16124
@tonyhutter
Copy link
Contributor Author

@behlendorf thanks, I included your changes in my latest push

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 29, 2024
@behlendorf behlendorf merged commit 4840f02 into openzfs:master Apr 29, 2024
14 of 25 checks passed
tonyhutter added a commit that referenced this pull request May 2, 2024
- Workaround dangling pointer in uu_list.c (#16124)
- Fix calloc() transposed arguments in zpool_vdev_os.c
- Make some temp variables unsigned to prevent triggering a
  '-Werror=alloc-size-larger-than' error.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #16124
Closes #16125
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
- Workaround dangling pointer in uu_list.c (openzfs#16124)
- Fix calloc() transposed arguments in zpool_vdev_os.c
- Make some temp variables unsigned to prevent triggering a
  '-Werror=alloc-size-larger-than' error.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#16124
Closes openzfs#16125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants