Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix arcstats for FreeBSD after zfetch support #16141

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix arcstats for FreeBSD after zfetch support #16141

merged 1 commit into from
Apr 29, 2024

Conversation

ixhamza
Copy link
Contributor

@ixhamza ixhamza commented Apr 28, 2024

Motivation and Context

arcstats fails in FreeBSD after 7b3e8d4 due to missing handling for zfetchstats there. This patch should fix the arcstats failure in FreeBSD.

Description

How Has This Been Tested?

Locally ran arcstats in FreeBSD environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ixhamza
fix arcstats for FreeBSD after zfetch support
e2fb425 
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
@AllKind AllKind mentioned this pull request Apr 28, 2024
Merged
13 tasks
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 29, 2024
@behlendorf behlendorf merged commit b28461b into openzfs:master Apr 29, 2024
22 of 26 checks passed
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 29, 2024
tonyhutter pushed a commit that referenced this pull request May 2, 2024
@ixhamza @tonyhutter
Fix arcstats for FreeBSD after zfetch support
b3b37b8 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes #16141
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@ixhamza @lundman
Fix arcstats for FreeBSD after zfetch support
e97f7cc 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ixhamza @behlendorf @amotin