Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/bash_completion.d: squelch FreeBSD seq when first < last #16234

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

derekschrock
Copy link
Contributor

With seq x -1 z and x is less than z FreeBSD seq will print the error:

$ seq 1 -1 2
seq: needs positive increment

Hide this error. Alternatively $COMP_CWORD could be checked for < 2.

Signed-off-by: Derek Schrock dereks@lifeofadishwasher.com

Motivation and Context

Hides an error message on FreeBSD seq if the number of words in the completion list is less than 2

Description

Send stderr to /dev/null

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

With seq x -1 z and x is less than z FreeBSD seq will print the error:

	$ seq 1 -1 2
	seq: needs positive increment

Hide this error.  Alternatively $COMP_CWORD could be checked for < 2.

Signed-off-by: Derek Schrock <dereks@lifeofadishwasher.com>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 29, 2024
@behlendorf behlendorf merged commit 4de260e into openzfs:master Jun 7, 2024
23 of 25 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
With seq x -1 z and x is less than z FreeBSD seq will print the error:

	$ seq 1 -1 2
	seq: needs positive increment

Hide this error.  Alternatively $COMP_CWORD could be checked for < 2.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Derek Schrock <dereks@lifeofadishwasher.com>
Closes openzfs#16234
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
With seq x -1 z and x is less than z FreeBSD seq will print the error:

	$ seq 1 -1 2
	seq: needs positive increment

Hide this error.  Alternatively $COMP_CWORD could be checked for < 2.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Derek Schrock <dereks@lifeofadishwasher.com>
Closes openzfs#16234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants