Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: restore zfs_znode_update_vfs() #16554

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

robn
Copy link
Member

@robn robn commented Sep 21, 2024

Motivation and Context

FreeBSD build produces a module that won't load.

Description

Restores function zfs_znode_update_vfs().

I accidentally removed this in c22d56e, and didn't notice because it doesn't fail the build, but does fail to load into the kernel because it can't link it.

How Has This Been Tested?

Compiled and loaded into kernel on 14.1-RELEASE-p3 and 13.4-RELEASE-p1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

I accidentally removed this in c22d56e, and didn't notice because it
doesn't fail the build, but does fail to load into the kernel because it
can't link it.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn robn changed the title FreeBSD: restore zfs_znode_update_vfs() FreeBSD: restore zfs_znode_update_vfs() Sep 21, 2024
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 21, 2024
@behlendorf behlendorf merged commit 80645d6 into openzfs:master Sep 21, 2024
5 of 20 checks passed
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 21, 2024
I accidentally removed this in c22d56e, and didn't notice because it
doesn't fail the build, but does fail to load into the kernel because it
can't link it.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#16554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants