Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Fix Summary Page #16555

Merged
merged 1 commit into from
Sep 22, 2024
Merged

ZTS: Fix Summary Page #16555

merged 1 commit into from
Sep 22, 2024

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Sep 21, 2024

Motivation and Context

The qemu-9-summary-page.sh script reads the file env.txt in the first lines. When the module didn't build, this file was not copied into the tarfile - causing the scipt to abort.

Fix: copy needed files into the tarfile in case of module build failures.
The fix ignores also empty tarfiles in future.

How Has This Been Tested?

Currently not tested, will see what ZTS thinks about it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Sorry, something went wrong.

The qemu-9-summary-page.sh script reads the file env.txt in the
first lines. When the module didn't build, this file was not copied
into the tarfile - causing the scipt to abort.

Fix: copy needed files into the tarfile in case of module build
failures. The fix ignores also empty tarfiles in future.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
@mcmilk
Copy link
Contributor Author

mcmilk commented Sep 21, 2024

Seems to work.
This run started without the fix for FreeBSD: https://github.com/mcmilk/zfs/actions/runs/10974229127
I cancelled the tests and the summary page was generated as expected.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 21, 2024
@behlendorf behlendorf merged commit 53b77c3 into openzfs:master Sep 22, 2024
9 of 20 checks passed
@mcmilk mcmilk deleted the zts-env.txt branch September 27, 2024 08:52
robn pushed a commit to robn/zfs that referenced this pull request Nov 5, 2024
The qemu-9-summary-page.sh script reads the file env.txt in the
first lines. When the module didn't build, this file was not copied
into the tarfile - causing the scipt to abort.

Fix: copy needed files into the tarfile in case of module build
failures. The fix ignores also empty tarfiles in future.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants