Define HAVE_KERNEL_NEON as (0) if not defined for simd_stat #16558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Chen
approved these changes
Sep 23, 2024
|
I happened to see this comment: 1d84c9e#commitcomment-147049188 So we may need such guard for each macro used in |
w0xel
force-pushed
the
hotfix/simd_stat_missing_define
branch
from
38f7d00 to
95e6aad
Compare
behlendorf
approved these changes
Sep 23, 2024
behlendorf
approved these changes
Sep 23, 2024
Signed-off-by: Sebastian Wuerl <s.wuerl@mailbox.org>
w0xel
force-pushed
the
hotfix/simd_stat_missing_define
branch
from
95e6aad to
801c258
Compare
behlendorf
added
Status: Accepted
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 14, 2024
This adds the HAVE_KERNEL_NEON and HAVE_KERNEL_FPU_INTERNAL guards to simd_stat.c defaulted to 0 to make it build again. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Shengqi Chen <harry-chen@outlook.com> Signed-off-by: Sebastian Wuerl <s.wuerl@mailbox.org> Closes openzfs#16558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently does not build for aarch64 on linux >= 6.2, as
HAVE_KERNEL_NEONwill not be defined, but used insimd_stat.c.Description
This adds the
HAVE_KERNEL_NEONtosimd_stat.cdefaulted to0to make it build again.How Has This Been Tested?
Built for aarch64 with latest
masterbefore, does not build witherror: 'HAVE_KERNEL_NEON' undeclared.Built for aarch64 again with this patch, does build again.
No other builds or tests were done.
Types of changes
Checklist:
Signed-off-by.Signed-off-by: Sebastian Wuerl s.wuerl@mailbox.org
Requires-builders: style arch