CI: run only sanity check on limited OSes for nonbehavioral changes #16564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Chen
force-pushed
the
reduce_ci_time
branch
3 times, most recently
from
cae6107 to
47e9139
Compare
|
Since upstream is still struggling with insufficient runners, I created a PR in my fork. When using quick mode, zfs-qemu takes about 20 minutes * 7 platforms (and can certainly be further reduced): https://github.com/Harry-Chen/zfs/actions/runs/11011261744 |
behlendorf
approved these changes
Sep 24, 2024
behlendorf
reviewed
Sep 24, 2024
behlendorf
reviewed
Sep 24, 2024
The commit uses heuristics to determine whether a PR is behavioral: It runs "quick" CI (i.e., only use sanity.run on fewer OSes) if (explicity required by user): - the *last* commit message contains a line 'ZFS-CI-Type: quick', or if (by heuristics): - the files changed are not in the list of specified directory, and - all commit messages does not contain 'ZFS-CI-Type: full'. It runs "full" CI otherwise. See: openzfs#16561 (comment) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Harry-Chen
force-pushed
the
reduce_ci_time
branch
from
47e9139 to
ae04fc6
Compare
Harry-Chen
changed the title
|
@behlendorf All suggestions applied. I also changed my wording from "trivial" to "nonbehavioral". Documentation & other stuff are also important to this project :-) |
mcmilk
approved these changes
Sep 25, 2024
behlendorf
added
Status: Accepted
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Nov 5, 2024
The commit uses heuristics to determine whether a PR is behavioral: It runs "quick" CI (i.e., only use sanity.run on fewer OSes) if (explicitly requested by user): - the *last* commit message contains a line 'ZFS-CI-Type: quick', or if (by heuristics): - the files changed are not in the list of specified directory, and - all commit messages does not contain 'ZFS-CI-Type: full'. It runs "full" CI otherwise. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Closes openzfs#16564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some small and nonbehavioral changes (e.g. to documentation or manpages) do not need a full CI run.
Description
The commit uses some heuristics to determine whether a PR is behavioral:
It runs "quick" CI (i.e., only use sanity.run on fewer OSes) if (explicity required by user):
It runs "full" CI otherwise.
See: #16561 (comment)
How Has This Been Tested?
Tested in my own fork: https://github.com/Harry-Chen/zfs/actions/runs/11011261744
Types of changes
(If enhancement to CI performance also counts.)
Checklist:
Signed-off-by.