Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packaging issues for native Debian packages #16604

Closed
wants to merge 3 commits into from
Closed

Fix packaging issues for native Debian packages #16604

wants to merge 3 commits into from

Conversation

usaleem-ix
Copy link
Contributor

Motivation and Context

#16513

Description

Fixes:
#15586
#15404
#14736
#15638

How Has This Been Tested?

  • Manually tested by building and installing packages prepared from release tarballs generated via make dist and other similar targets.
  • Manual invocation make -j native deb or make -j native-deb-utils native-deb-kmod does not break.
  • zfs-zed.service runs correctly after installing the package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@satmandu
Copy link
Contributor

satmandu commented Oct 4, 2024 •
edited
Loading

Would it make sense to synchronize with what Debian uses downstream?

i.e., https://salsa.debian.org/zfsonlinux-team/zfs/-/tree/master/debian?ref_type=heads

@usaleem-ix
Fix missing packaging files from release tarballs
6485d52 
Properly distribute files for native Debian packages. This fixes the
issue with broken release tarballs.

Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes#15404
Closes#15586
@usaleem-ix
Disable parallel build for native-deb* targets
a8b1a09 
Running native-deb* targets in parallel via make is not supported.

Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes#14736
@usaleem-ix
Update path for zed in zfs-zed.service for native debian packages
f4dbb9d 
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes#15638
@amotin amotin requested a review from behlendorf October 4, 2024 15:47
@usaleem-ix
Copy link
Contributor Author

Would it make sense to synchronize with what Debian uses downstream?

i.e., https://salsa.debian.org/zfsonlinux-team/zfs/-/tree/master/debian?ref_type=heads

This can be a topic of another PR, since it would require more testing and would take some time to validate all the bits. The purpose of this PR is to fix packaging issues that are currently open. Hopefully, before zfs-2.3 branch out.

@behlendorf
Copy link
Contributor

Thanks for fixing up these issues with the packaging for everyone. I'll pull them in once the CI looks good and let you know if I see any other reports of problems.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 4, 2024
@behlendorf
Copy link
Contributor

Merged as:

45addf7 Update path for zed in zfs-zed.service for native debian packages
cc9e36a Disable parallel build for native-deb* targets
c204c3f Fix missing packaging files from release tarballs

@behlendorf behlendorf closed this Oct 4, 2024
@behlendorf behlendorf mentioned this pull request Oct 4, 2024
Closed
@usaleem-ix usaleem-ix deleted the fix-packaging branch October 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usaleem-ix @satmandu @behlendorf