ZTS: Fix summary page creation again - second try #16611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
behlendorf
approved these changes
Oct 6, 2024
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 8, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#16611
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 9, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#16611
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Oct 9, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#16611
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 9, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#16611
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Nov 5, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#16611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In PR #16599 I used
returnlike inC- which is wrong :/The
returnwill return / exit the whole script with an error... so no summary will be genereted et all.This fix generates the summary as needed again.
Types of changes
Checklist:
Signed-off-by.