Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misuse of input argument in traverse_visitbp #3348

Closed
wants to merge 1 commit into from
Closed

Fix misuse of input argument in traverse_visitbp #3348

wants to merge 1 commit into from

Commits on Apr 26, 2015

  1. Fix misuse of input argument in traverse_visitbp 

    In traverse_visitbp(), the input argument dnp is modified in the middle to
point to a temporary buffer. Originally this doesn't matter, because no user
of TRAVERSE_POST dereferences it. However, in fbeddd6 a piece of code is added
dereferencing dnp after the modification, creating a possible bug.

We fix this by creating a new local variable cdnp for the DMU_OT_DNODE case,
so we don't modify the input argument. Also we introduce different local
variables in the DMU_OT_OBJSET case to prevent confusion between the input
argument.

Signed-off-by: Chunwei Chen <tuxoko@gmail.com>
    @tuxoko
    tuxoko committed Apr 26, 2015
    Configuration menu
    Copy the full SHA
    a585f2f View commit details
    Browse the repository at this point in the history