Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve DMU_BACKUP_FEATURE for ZSTD #7626

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

allanjude
Copy link
Contributor

@allanjude allanjude commented Jun 12, 2018

Reserve bit 25 in the zfs replication DMU_BACKUP_FEATURE bitfield for the ZSTD compression feature from FreeBSD.

Requires-builders: none

Description / Motivation

Reserve a bit in the DMU_BACKUP_FEATURE namespace for the ZSTD compression feature, to prevent future merge conflicts.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@behlendorf
Copy link
Contributor

@allanjude would you mind adding your signed-of-by and force updating this PR so we can merge it.

Reserve bit 25 for the ZSTD compression feature from FreeBSD.

Signed-off-by: Allan Jude <allanjude@freebsd.org>
@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #7626 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
+ Coverage   77.51%   77.56%   +0.04%     
==========================================
  Files         363      363              
  Lines      110517   110517              
==========================================
+ Hits        85672    85723      +51     
+ Misses      24845    24794      -51
Flag Coverage Δ
#kernel 78.22% <ø> (-0.19%) ⬇️
#user 66.47% <ø> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232dd8b...c818c5d. Read the comment docs.

@behlendorf behlendorf merged commit 29445fe into openzfs:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants