zstreamdump: include embedded writes in total_write_size #8431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstreamdump outputs a summary at the end that includes the total byte count of all DRR_WRITE records. This change makes it also include the bytes from DRR_WRITE_EMBEDDED records, where the data was small enough to be embedded directly into the block pointer. Signed-off-by: Allan Jude <allanjude@freebsd.org>
Codecov Report
@@ Coverage Diff @@
## master #8431 +/- ##
==========================================
+ Coverage 78.43% 78.61% +0.18%
==========================================
Files 380 380
Lines 115901 115902 +1
==========================================
+ Hits 90909 91122 +213
+ Misses 24992 24780 -212
Continue to review full report at Codecov.
|
behlendorf
reviewed
Feb 21, 2019
There was a problem hiding this comment.
If we're expanding what is encompassed by total_write_size we may want to include the payload for DRR_SPILL records too. Or conversely remove total_write_size and instead depend on your new per-record sizes from #8432.
ahrens
approved these changes
Feb 27, 2019
behlendorf
approved these changes
Mar 3, 2019
behlendorf
added
Status: Accepted
|
I'd like to see #8432 completed! |
|
@allanjude shall we close this out in favor of an updated #8432? |
|
Closing for now, let's tackle this in the context of a completed #8432. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allan Jude allanjude@freebsd.org
Motivation and Context
zstreamdump is a tool used to analyze the contents of ZFS replication streams.
zstreamdump outputs a summary at the end that includes the total byte
count of all DRR_WRITE records. This excludes the bytes from any
DRR_WRITE_EMBEDDED records, resulting in a total that is not accurate.
DRR_WRITE_EMBEDDED records are only included in a replication stream if it is
generated with
zfs send -e.Description
This change includes the payload size of any embedded write records in the
total_write_sizestatistic displayed at the end of the zstreamdump run.How Has This Been Tested?
zfs send -e dataset@snapshot | zstreamdumpTypes of changes
Checklist:
Signed-off-by.